-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Halyard): s3 --bucket not accept s3:// prefix #951
Conversation
Solution to "Halyard: s3 --bucket will not accetp s3:// prefix #2408" Better solution might be is to find out why the parameter cannot be stored with the s3:// because it should be needed to access the s3 bucket. Possibly the validate function cannot handle the s3:// prefix and the code needed when the bucket is accessed would need updating so this might be the easiest solution.
The following commits need their title changed: e261d82: Update S3EditCommand.java for problem #2408 Solution to "Halyard: s3 --bucket will not accetp s3:// prefix #2408" Better solution might be is to find out why the parameter cannot be stored with the s3:// because it should be needed to access the s3 bucket. Possibly the validate function cannot handle the s3:// prefix and the code needed when the bucket is accessed would need updating so this might be the easiest solution. Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please amend your commit message (not the PR title) & I'll merge
What should be in it?
Beginner here.
…On Fri, May 25, 2018, 2:18 PM Lars Wander ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks! Please amend your commit message (not the PR title) & I'll merge
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#951 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH3hPP5zJ1E-3CqUT1mIU5vtuFYsBMtYks5t2FkRgaJpZM4UOFLy>
.
|
Oh was this change made via the web-UI? if so, I think I can just edit it from here. |
Solution to "Halyard: s3 --bucket will not accetp s3:// prefix #2408" Better solution might be is to find out why the parameter cannot be stored with the s3:// because it should be needed to access the s3 bucket. Possibly the validate function cannot handle the s3:// prefix and the code needed when the bucket is accessed would need updating so this might be the easiest solution.
I think I was able to fix the commit message |
Nice! thanks :) |
Solution to "Halyard: s3 --bucket will not accetp s3:// prefix #2408"
fixes #2408
Better solution might be is to find out why the parameter cannot be stored with the s3:// because it should be needed to access the s3 bucket. Possibly the validate function cannot handle the s3:// prefix and the code needed when the bucket is accessed would need updating so this might be the easiest solution.