Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the kubernetes proxyServiceEndpoint #933

Merged
merged 1 commit into from
May 9, 2018
Merged

Change the kubernetes proxyServiceEndpoint #933

merged 1 commit into from
May 9, 2018

Conversation

kangwoo
Copy link
Contributor

@kangwoo kangwoo commented May 4, 2018

Fixed an issue spinnaker/spinnaker#2728

hal deploy apply uses the old style proxy path for kubernetes which was removed in v1.10

@lwander
Copy link
Member

lwander commented May 4, 2018

What happens if this is run against clusters prior to 1.10?

@kangwoo
Copy link
Contributor Author

kangwoo commented May 8, 2018

It works fine with version 1.2 or later.

@ezimanyi ezimanyi mentioned this pull request May 9, 2018
Closed
@ezimanyi ezimanyi self-requested a review May 9, 2018 15:11
ezimanyi
ezimanyi approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ezimanyi
Copy link
Contributor

ezimanyi commented May 9, 2018

One small point---the new endpoint requires the services/proxy RBAC permission whereas the old one did not. I'm going to push a small change to improve the error message when that permission is lacking to make it easier for anyone who runs into that issue to diagnose and fix it.

@ezimanyi ezimanyi merged commit 63e2607 into spinnaker:master May 9, 2018
@kangwoo
Copy link
Contributor Author

kangwoo commented May 11, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kangwoo @lwander @ezimanyi @kangwoo-line