Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosco): Preserve file permissions for local git installation #927

Merged
merged 1 commit into from
Apr 27, 2018
Merged

fix(rosco): Preserve file permissions for local git installation #927

merged 1 commit into from
Apr 27, 2018

Conversation

ezimanyi
Copy link
Contributor

Fixes an issue whereby executable files in the packer config directory
would get their execute bit unset when deploying halyard in the local
git mode.

Fixes an issue whereby executable files in the packer config directory
would get their execute bit unset when deploying halyard in the local
git mode.
@ezimanyi ezimanyi requested a review from lwander April 27, 2018 21:33
@ezimanyi
Copy link
Contributor Author

ezimanyi commented Apr 27, 2018

It's sort of annoying that I had to write functions to convert between java.nio file permissions and apache.commons file bits, but I couldn't find a reasonable library to do this.

This fixes a minor issue, but it's been particularly annoying as I've been working on default packer configs and Halyard keeps causing conflicts with my local changes.

Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, nice

@ezimanyi ezimanyi merged commit 47d6eee into spinnaker:master Apr 27, 2018
@ezimanyi ezimanyi deleted the fix-file-permissions branch April 27, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants