Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(local): strip local: prefix before deploying, allow non-semvar … #922

Merged
merged 1 commit into from
Apr 23, 2018
Merged

fix(local): strip local: prefix before deploying, allow non-semvar … #922

merged 1 commit into from
Apr 23, 2018

Conversation

danielpeach
Copy link
Contributor

…gate versions

danielpeach
danielpeach commented Apr 23, 2018
View reviewed changes
...loy/src/main/java/com/netflix/spinnaker/halyard/deploy/spinnaker/v1/service/GateService.java
@@ -84,8 +86,12 @@ public Type getType() {

private GateProfileFactory getGateProfileFactory(String deploymentName) {
String version = artifactService.getArtifactVersion(deploymentName, SpinnakerArtifact.GATE);
if (Versions.lessThan(version, BOOT_UPGRADED_VERSION)) {
return boot128ProfileFactory;
try {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't here to handle the local: prefix, it's here so that my gate image tag doesn't have to follow semvar.

@danielpeach danielpeach merged commit cffa381 into spinnaker:master Apr 23, 2018
@danielpeach danielpeach deleted the local-deploy-fixes branch April 23, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danielpeach @lwander