Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gcs): assign scopes to app default creds when needed #920

Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix(gcs): assign scopes to app default creds when needed #920

merged 1 commit into from
Apr 19, 2018

Conversation

lwander
Copy link
Member

@lwander lwander commented Apr 19, 2018

No description provided.

@lwander lwander requested a review from ewiseblatt April 19, 2018 15:11
ewiseblatt
ewiseblatt approved these changes Apr 19, 2018
View reviewed changes
Copy link

@ewiseblatt ewiseblatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@lwander lwander merged commit 1703a89 into spinnaker:master Apr 19, 2018
@lwander lwander deleted the create-with-scopes branch April 19, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewiseblatt ewiseblatt ewiseblatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lwander @ewiseblatt