Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider/appengine): add feature flag to enable container image url deployments #896

Merged
1 commit merged into from Apr 9, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2018

No description provided.

@ghost ghost requested review from lwander and danielpeach April 6, 2018 17:04
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a symmetric halconfig/settings.js change in deck, right?

@danielpeach
Copy link
Contributor

danielpeach commented Apr 9, 2018

That's here: spinnaker/deck#5126, but that means that the @ValidForSpinnaker annotation should be for a later version, since the halconfig for 1.6.0 won't have that change.

@ghost
Copy link
Author

ghost commented Apr 9, 2018

@ghost
Copy link
Author

ghost commented Apr 9, 2018

Pushed it back to a minimum version of 1.7.0

@ghost ghost merged commit 4a5f167 into spinnaker:master Apr 9, 2018
@ghost ghost deleted the appengine-container-image-url-deployments branch April 9, 2018 17:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants