Halyard: Support loading BOM from disk rather than GCS #2390 #894
Conversation
…a BOM from a configurable path on the local disk if the specified Spinnaker version starts with 'local:'.
…der to read artefact profiles from the local BOM path.
… localDiskProfileReader behaves correctly with well-formed and malformed paths, and checking if localDiskProfileReader performs correctly when reading files from tar archive.
…ocaldisk-tests Feature/read bom from localdisk tests
…ocaldisk Add feature to read Bill of Materials from a location on disk, with basic unit tests.
| @@ -1,6 +1,6 @@ | |||
| #Mon Dec 11 14:43:59 EST 2017 | |||
| #Tue Apr 03 13:32:29 SAST 2018 | |||
There was a problem hiding this comment.
I think your build system/IDE made these changes. Can you back these out?
gradlew
Outdated
| @@ -1,17 +1,35 @@ | |||
| #!/usr/bin/env bash | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
I think your build system/IDE made these changes. Can you back these out?
gradlew.bat
Outdated
| @@ -8,14 +8,14 @@ | |||
| @rem Set local scope for the variables with windows NT shell | |||
| if "%OS%"=="Windows_NT" setlocal | |||
|
|
|||
| @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | |||
There was a problem hiding this comment.
I think your build system/IDE made these changes. Can you back these out?
| return new FileInputStream(objectName); | ||
| } | ||
|
|
||
| } |
| @@ -0,0 +1,113 @@ | |||
| /* | |||
| * Copyright 2017 Google, Inc. | |||
There was a problem hiding this comment.
You should make this 2018, and your company or name
| @@ -0,0 +1,122 @@ | |||
| /* | |||
| * Copyright 2017 Google, Inc. | |||
There was a problem hiding this comment.
Same comment here about updating this.
| @@ -67,7 +72,7 @@ String gitRoot(@Value("${git.root:~/dev/spinnaker}") String gitRoot) { | |||
| } | |||
|
|
|||
| @Bean | |||
| String spinnakerStagingDependencyPath(@Value("${spinnaker.config.staging.directory:~/.halyard}") String path) { | |||
| String spinnakerStagingDependencyPath(@Value("${spinnaker.config.staging.directory:~/.hal}") String path) { | |||
There was a problem hiding this comment.
Is this fixing an outstanding bug, or a change for this feature?
|
Once this is merged, would you be OK if I make some more changes around this, namely stopping all requests to the global |
Spock has access to private members.
|
Can you please provide the documentation on how to achieve the offline installation of spinnaker. Thanks |
|
@Tharun-Sabbu still looking for it. Do you have a link for me after 2 years ? |
@lwander