Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kayenta/aws): First pass at support for configuring AWS canary s… #892

Merged
merged 1 commit into from
Apr 4, 2018
Merged

feat(kayenta/aws): First pass at support for configuring AWS canary s… #892

merged 1 commit into from
Apr 4, 2018

Conversation

duftler
Copy link

@duftler duftler commented Apr 4, 2018

…ervice integration.

@duftler duftler requested a review from lwander April 4, 2018 18:31
lwander
lwander approved these changes Apr 4, 2018
View reviewed changes
...src/main/java/com/netflix/spinnaker/halyard/config/model/v1/canary/aws/AwsCanaryAccount.java Outdated
private Set<AbstractCanaryServiceIntegration.SupportedTypes> supportedTypes = new HashSet<>();

// @JsonIgnore
// public GoogleNamedAccountCredentials getNamedAccountCredentials(String version, ConfigProblemSetBuilder p) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe to remove?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@duftler duftler merged commit 013c4c2 into spinnaker:master Apr 4, 2018
@duftler duftler deleted the kayenta-amazon branch April 4, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@duftler @lwander