-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes-v2): first steps for a v2 deployer #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -37,7 +37,7 @@ | |||
public class ResponseUnwrapper { | |||
private static final Long WAIT_MILLIS = 400L; | |||
private static int cycle; | |||
private static String[] cursors = {".", "-", "^"}; | |||
private static String[] cursors = {"_", "-", "^", "*"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a 1.0 worthy change
@@ -6,4 +6,5 @@ dependencies { | |||
compile spinnaker.dependency('googleStorage') | |||
|
|||
compile 'com.beust:jcommander:1.48' | |||
compile 'com.hubspot.jinjava:jinjava:2.2.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exists in a few places now, need to add to spinnaker-dependencies eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still pretty fresh in our codebase - both the artifact & (now this) is largely unproven
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright 2017 Google, Inc. | |||
* Copyright 2018 Google, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was representing file creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Remaining work is listed here: spinnaker/spinnaker#2176