feat(kubernetes-v2): first steps for a v2 deployer #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtk54
approved these changes
Jan 25, 2018
| @@ -37,7 +37,7 @@ | |||
| public class ResponseUnwrapper { | |||
| private static final Long WAIT_MILLIS = 400L; | |||
| private static int cycle; | |||
| private static String[] cursors = {".", "-", "^"}; | |||
| private static String[] cursors = {"_", "-", "^", "*"}; | |||
There was a problem hiding this comment.
I think this is a 1.0 worthy change
| @@ -6,4 +6,5 @@ dependencies { | |||
| compile spinnaker.dependency('googleStorage') | |||
|
|
|||
| compile 'com.beust:jcommander:1.48' | |||
| compile 'com.hubspot.jinjava:jinjava:2.2.3' | |||
There was a problem hiding this comment.
This exists in a few places now, need to add to spinnaker-dependencies eventually.
There was a problem hiding this comment.
It's still pretty fresh in our codebase - both the artifact & (now this) is largely unproven
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2017 Google, Inc. | |||
| * Copyright 2018 Google, Inc. | |||
There was a problem hiding this comment.
I thought this was representing file creation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining work is listed here: spinnaker/spinnaker#2176