-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localgit): Remove and then add git remote #818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run `git remote add upstream` when `upstream` already exists, we get the annoying output `fatal: remote upstream already exists.` for every component. Run `git remote remove upstream` first to avoid printing this error. This also mimics the behavior of the newer git command `git remote set-url` that we use when git is above a certain version.
Example of current output of
|
lwander
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
davidxia
added a commit
to davidxia/halyard
that referenced
this pull request
Jan 24, 2018
The remote "upstream" might not exist. Do not fail if so. fixes bug introduced in spinnaker#818
lwander
pushed a commit
that referenced
this pull request
Jan 24, 2018
The remote "upstream" might not exist. Do not fail if so. fixes bug introduced in #818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we run
git remote add upstream
whenupstream
alreadyexists, we get the annoying output
fatal: remote upstream already exists.
for every component.
Run
git remote remove upstream
first to avoid printing this error.This also mimics the behavior of the newer git command
git remote set-url
that we use when git is above a certain version.