Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a default GlobalApplicationOptions instance if no config file. #817

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

msilpala
Copy link
Contributor

This is not a complete solution yet, but this seems to correct one of the issues I'm seeing when running a local halyard on macOS.

Still getting this error when trying to set the version via CLI:

$ hal config version edit --version 1.5.4
+ Get current deployment
  Success
- Edit Spinnaker version
  Failure
Problems in Global:
! ERROR Unexpected exception: java.lang.NullPointerException

- Failed to update version.

Meanwhie, the daemon spits this out to its console:

2018-01-19 17:58:57.182  WARN 37078 --- [       Thread-6] c.n.s.h.core.tasks.v1.TaskRepository     : Task [Edit Spinnaker version] (56525576-c51a-4d43-825c-499d5a0e1595) - RUNNING failed with unexpected reason: 

java.lang.NullPointerException: null
	at com.netflix.spinnaker.halyard.core.DaemonResponse$UpdateRequestBuilder.build(DaemonResponse.java:168) ~[halyard-core-0.31.0-SNAPSHOT.jar:0.31.0-SNAPSHOT]
	at com.netflix.spinnaker.halyard.core.tasks.v1.TaskRepository.lambda$submitTask$1(TaskRepository.java:48) ~[halyard-core-0.31.0-SNAPSHOT.jar:0.31.0-SNAPSHOT]
	at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_141]

2018-01-19 17:58:57.183  INFO 37078 --- [       Thread-6] c.n.s.halyard.core.tasks.v1.DaemonTask   : [Edit Spinnaker version] (56525576-c51a-4d43-825c-499d5a0e1595) - FAILED killing all jobs created by this task 
2018-01-19 17:58:57.183  INFO 37078 --- [       Thread-6] c.n.s.h.core.tasks.v1.TaskRepository     : Task [Edit Spinnaker version] (56525576-c51a-4d43-825c-499d5a0e1595) - FAILED completed

@lwander
Copy link
Member

lwander commented Jan 23, 2018

Ah, ha: #820

@lwander lwander merged commit 5bb27cf into spinnaker:master Jan 23, 2018
@msilpala msilpala deleted the global-config-fix branch March 22, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants