feat(provider/appengine): add command for configuring gcloud release track #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, could you mention the alpha beta and stable release tracks as options
in the parameter description?
…On Fri, Dec 8, 2017, 3:34 PM Daniel Peach ***@***.***> wrote:
@danielpeach <https://github.com/danielpeach> requested your review on:
spinnaker/halyard#783 <#783>
feat(provider/appengine): add command for configuring gcloud version.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#783 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEpivUxa3Ebnkjic87NrfZEU5NAO0aTdks5s-atYgaJpZM4Q7rK2>
.
|
danielpeach
force-pushed
the
appengine-gcloud-version
branch
from
db591a1
to
d540a73
Compare
danielpeach
force-pushed
the
appengine-gcloud-version
branch
from
d540a73
to
1e95d0c
Compare
|
Done. |
danielpeach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.