Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mineCanary): feature flag for legacy canary support #759

Merged
merged 3 commits into from
Nov 9, 2017

Conversation

rebalag
Copy link
Contributor

@rebalag rebalag commented Nov 7, 2017

Update halyard command line to enable/disable canary feature flag in deck settings.js

hal config features edit --legacyCanary false
hal config features edit --legacyCanary true

Update halyard command line to enable/disable canary feature flag in deck settings
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 2 small comments & I'll merge

@@ -63,6 +63,14 @@
)
private Boolean artifacts = null;

@Parameter(
names = "--legacyCanary",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to 'kebab-case' for flags (--legacy-canary)

@Parameter(
names = "--legacyCanary",
description = "Enable legacy canary support. For this to work, you'll need a canary judge configured."
+ "Currently, halyard does not configure canary judge for you",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a period, and 'Halyard' is typically capitalized here.

Change command line flag to kebab case and contextual name mine-canary
hal config features edit --mine-canary true
hal config features edit --mine-canary false
@@ -1095,6 +1095,7 @@ hal config features edit [parameters]
* `--chaos`: Enable Chaos Monkey support. For this to work, you'll need a running Chaos Monkey deployment. Currently, Halyard doesn't configure Chaos Monkey for you; read more instructions here https://github.com/Netflix/chaosmonkey/wiki.
* `--deployment`: If supplied, use this Halyard deployment. This will _not_ create a new deployment.
* `--jobs`: Allow Spinnaker to run containers in Kubernetes and Titus as Job stages in pipelines.
* `--mine-canary`: Enable canary support. For this to work, you'll need a canary judge configured. Currently, Halyard does not configure canary judge for you.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is called mine-canary now? That might get confusing when we open source the new canary judge, and users don't understand what the difference between mine and kayenta is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked out-of-band - this makes sense. Can we update settings.js too just so we don't get caught on this in the future?

@@ -94,6 +94,7 @@ protected void setProfile(Profile profile, DeploymentConfiguration deploymentCon
bindings.put("features.fiat", Boolean.toString(deploymentConfiguration.getSecurity().getAuthz().isEnabled()));
bindings.put("features.pipelineTemplates", Boolean.toString(features.getPipelineTemplates() != null ? features.getPipelineTemplates() : false));
bindings.put("features.artifacts", Boolean.toString(features.getArtifacts() != null ? features.getArtifacts() : false));
bindings.put("features.legacyCanary", Boolean.toString(features.getLegacyCanary() != null ? features.getLegacyCanary() : false));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read mineCanary now

cleanup code to propogate feature name as mineCanary from CLI to config file
hal config features edit --mine-canary true
hal config features edit --mine-canary false
@lwander lwander merged commit 1bbaa47 into spinnaker:master Nov 9, 2017
@lwander lwander changed the title feat(legacyCanary): feature flag for legacy canary support feat(mineCanary): feature flag for legacy canary support Nov 9, 2017
@lwander
Copy link
Member

lwander commented Nov 9, 2017

Will cut a release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants