Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifacts): feature flag artifact support #751

Merged
merged 1 commit into from
Nov 3, 2017
Merged

feat(artifacts): feature flag artifact support #751

merged 1 commit into from
Nov 3, 2017

Conversation

lwander
Copy link
Member

@lwander lwander commented Nov 3, 2017

No description provided.

jtk54
jtk54 approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

danielpeach
danielpeach approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@danielpeach danielpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming you know there's no spinnaker.io/reference/artifacts.

@lwander
Copy link
Member Author

lwander commented Nov 3, 2017

Yup, not yet

@lwander lwander merged commit 8c3ed28 into spinnaker:master Nov 3, 2017
@lwander lwander deleted the artifact-feature branch November 3, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtk54 jtk54 jtk54 approved these changes

@danielpeach danielpeach danielpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lwander @jtk54 @danielpeach