Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(travis): Add numberOfRepositories configuration #744

Merged

Conversation

gardleopard
Copy link
Contributor

Support the new configuration field (spinnaker/igor#193)

names = "--number-of-repositories",
description = TravisCommandProperties.NUMBER_OF_REPOSITORIES_DESCRIPTION
)
public int numberOfRepositories = 25;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you provide a default here, it will be set everytime someone runs edit on this command, even if they don't intend to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will fix this.

@lwander lwander merged commit 06dad0e into spinnaker:master Nov 1, 2017
@gardleopard gardleopard deleted the travis_number_of_repositories branch November 2, 2017 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants