-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authn): Add subjectPrincipalRegex edit option to x509 command #715
feat(authn): Add subjectPrincipalRegex edit option to x509 command #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor editorial comments
docs/commands.md
Outdated
#### Parameters | ||
* `--deployment`: If supplied, use this Halyard deployment. This will _not_ create a new deployment. | ||
* `--no-validate`: (*Default*: `false`) Skip validation. | ||
* `--role-oid`: The OID that encodes roles that the user specified in the x509 certificatebelongs to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a space on this line between certificate
and belongs
docs/commands.md
Outdated
* `--deployment`: If supplied, use this Halyard deployment. This will _not_ create a new deployment. | ||
* `--no-validate`: (*Default*: `false`) Skip validation. | ||
* `--role-oid`: The OID that encodes roles that the user specified in the x509 certificatebelongs to | ||
* `--subject-principal-regex`: The regex used to parse the subject principle name embedded in the x509certificate if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space after x509
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also principal
not principle
@@ -42,13 +42,21 @@ | |||
@Parameter( | |||
names = "--role-oid", | |||
description = "The OID that encodes roles that the user specified in the x509 certificate" + | |||
" belongs to" | |||
"belongs to" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should leave the space here otherwise the string runs together.
) | ||
private String roleOid; | ||
|
||
@Parameter( | ||
names = "--subject-principal-regex", | ||
description = "The regex used to parse the subject principle name embedded in the x509" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
principal
not principle
@Parameter( | ||
names = "--subject-principal-regex", | ||
description = "The regex used to parse the subject principle name embedded in the x509" + | ||
"certificate if necessary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a space at the beginning so the string doesn't run together.
579d3b9
to
2afe695
Compare
Forgot to make docs for these commands in the last PR so I ran it this time.