feat(authn): Add subjectPrincipalRegex edit option to x509 command #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
approved these changes
Sep 27, 2017
docs/commands.md
Outdated
| #### Parameters | ||
| * `--deployment`: If supplied, use this Halyard deployment. This will _not_ create a new deployment. | ||
| * `--no-validate`: (*Default*: `false`) Skip validation. | ||
| * `--role-oid`: The OID that encodes roles that the user specified in the x509 certificatebelongs to |
There was a problem hiding this comment.
missing a space on this line between certificate and belongs
docs/commands.md
Outdated
| * `--deployment`: If supplied, use this Halyard deployment. This will _not_ create a new deployment. | ||
| * `--no-validate`: (*Default*: `false`) Skip validation. | ||
| * `--role-oid`: The OID that encodes roles that the user specified in the x509 certificatebelongs to | ||
| * `--subject-principal-regex`: The regex used to parse the subject principle name embedded in the x509certificate if necessary |
There was a problem hiding this comment.
missing space after x509
There was a problem hiding this comment.
also principal not principle
| @@ -42,13 +42,21 @@ | |||
| @Parameter( | |||
| names = "--role-oid", | |||
| description = "The OID that encodes roles that the user specified in the x509 certificate" + | |||
| " belongs to" | |||
| "belongs to" | |||
There was a problem hiding this comment.
Should leave the space here otherwise the string runs together.
| ) | ||
| private String roleOid; | ||
|
|
||
| @Parameter( | ||
| names = "--subject-principal-regex", | ||
| description = "The regex used to parse the subject principle name embedded in the x509" + |
There was a problem hiding this comment.
principal not principle
| @Parameter( | ||
| names = "--subject-principal-regex", | ||
| description = "The regex used to parse the subject principle name embedded in the x509" + | ||
| "certificate if necessary" |
There was a problem hiding this comment.
Need a space at the beginning so the string doesn't run together.
edwinavalos
force-pushed
the
adding-x509-subject-principal
branch
from
579d3b9
to
2afe695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to make docs for these commands in the last PR so I ran it this time.