Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(springBoot): Update Gate's Spring Boot upgrade version #687

Merged
merged 1 commit into from
Sep 8, 2017
Merged

fix(springBoot): Update Gate's Spring Boot upgrade version #687

merged 1 commit into from
Sep 8, 2017

Conversation

ttomsu
Copy link
Member

@ttomsu ttomsu commented Sep 8, 2017

No description provided.

@ttomsu ttomsu requested a review from lwander September 8, 2017 15:21
lwander
lwander approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, are we positive that only spinnaker 1.3 uses gate 0.7?

@lwander
Copy link
Member

lwander commented Sep 8, 2017

1.2.2 is on 0.6.0 - so we should be good

@ttomsu
Copy link
Member Author

ttomsu commented Sep 8, 2017

it assumes all gate versions beyond 0.7 will have boot 1.5.4 - https://github.com/spinnaker/halyard/pull/687/files#diff-97de087204983a5ea7f11564f3b5ceddR87

@lwander lwander merged commit 287f356 into master Sep 8, 2017
@lwander lwander deleted the ttomsu-patch-1 branch September 8, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ttomsu @lwander