Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config/orca): append singular form and plural form of pipelineTemplates #666

Merged
merged 1 commit into from Aug 16, 2017
Merged

Conversation

idoshamun
Copy link
Contributor

To support old versions of orca, it is needed to append also the singular form and not just the plural.

#664

…plates

To support old versions of orca, it is needed to append also the singular form
and not just the plural.
@idoshamun
Copy link
Contributor Author

Please note that I didn't change orca-bootstrap profile as older version don't enable it by default so there is no need to add backward compatibility there, if needed let me know

Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good thinking. I was assuming we were dropping the old config, but this is best

@lwander lwander merged commit 03d222a into spinnaker:master Aug 16, 2017
@lwander
Copy link
Member

lwander commented Aug 16, 2017

I've added to the older orca-bootstrap profile as well because even if it's not added by default it will still be picked up in the orca.yml profile

@idoshamun idoshamun deleted the pipeline-templates-backward branch August 16, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants