Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add examples for some authn properties. #657

Merged
merged 1 commit into from
Aug 14, 2017
Merged

[WIP] Add examples for some authn properties. #657

merged 1 commit into from
Aug 14, 2017

Conversation

markus-silpala-tgt
Copy link
Contributor

Includes a quick set of SAML properties, and a first property (commented out) with which to test-drive the LDAP implementation that my Target peeps are working today.

Technically, we could merge this now and fill in the rest of the properties in separate PR's. But I prefer not to merge commented-out stuff to master.

Includes a quick set of SAML properties, and a first property with which to test-drive LDAP.
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lwander lwander merged commit 2585893 into spinnaker:master Aug 14, 2017
@lwander
Copy link
Member

lwander commented Aug 14, 2017

Sorry! Merged w/o carefully reading...

@markus-silpala-tgt markus-silpala-tgt deleted the spec_for_ldap_auth branch August 15, 2017 02:37
@markus-silpala-tgt
Copy link
Contributor Author

No worries! My clean-code preference notwithstanding, there's value in keeping branches' lives short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants