Pipeline template feature flag / 'ValidForSpinnakerVersion' annotation. #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpeach
force-pushed
the
pipeline-templates
branch
6 times, most recently
from
d22663c
to
a7c28a3
Compare
lwander
approved these changes
Aug 2, 2017
| @@ -62,6 +69,11 @@ protected void executeThis() { | |||
|
|
|||
| features.setChaos(chaos != null ? chaos : features.isChaos()); | |||
| features.setJobs(jobs != null ? jobs : features.isJobs()); | |||
| if (!pipelineTemplates) { | |||
There was a problem hiding this comment.
If this var is null I think java will crash here with an NPE
| @@ -43,6 +43,7 @@ public NodeIterator getChildren() { | |||
| private boolean chaos; | |||
| private boolean entityTags; | |||
| private boolean jobs; | |||
| @ValidForSpinnakerVersion(lowerBound = "1.2.0") private Boolean pipelineTemplates; | |||
|
|
||
| return runMatchingValidators(psBuilder, validator, node, c.getSuperclass()) + result; | ||
|
|
||
| if (result > 0) { |
There was a problem hiding this comment.
Given that result can be either 1 or 0 and nothing else I think a bool is more appropriate here. Returning a bool makes more sense then too.
| if (fieldNotValid) { | ||
| p.addProblem(Problem.Severity.WARNING, "Field " + clazz.getSimpleName() + "." + field.getName() | ||
| + " not supported for Spinnaker version " + spinnakerVersion + "." | ||
| + " Use at least " + annotation.lowerBound() + "."); |
There was a problem hiding this comment.
This last "help" text should be set in .setRemediation(String) which can be called on the result of .addProblem()
|
Yes, verified that settings.js is written properly for 1.1.2. |
danielpeach
force-pushed
the
pipeline-templates
branch
from
a7c28a3
to
4d33a48
Compare
|
Addressed comments. |
danielpeach
force-pushed
the
pipeline-templates
branch
2 times, most recently
from
3434d2b
to
3c57106
Compare
danielpeach
force-pushed
the
pipeline-templates
branch
from
3c57106
to
de9201e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lwander please review.