Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support talking to a remote Daemon from the CLI #623

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Support talking to a remote Daemon from the CLI #623

merged 1 commit into from
Jul 21, 2017

Conversation

johnrengelman
Copy link
Contributor

No description provided.

@johnrengelman johnrengelman changed the title Support passing it a remote daemon address. Support talking to a remote Daemon from the CLI Jul 21, 2017
lwander
lwander reviewed Jul 21, 2017
View reviewed changes
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm wondering if this should be augmented with a config file at something like ~/.hal/cli or similar so that users don't have to pass --daemon-endpoint with every command. Thoughts?

halyard-cli/src/main/java/com/netflix/spinnaker/halyard/cli/services/v1/Daemon.java
@@ -643,15 +643,12 @@ private static ObjectMapper getObjectMapper() {
return objectMapper;
}

// TODO(lwander): setup config file for this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@johnrengelman
Copy link
Contributor Author

I think a config file would make sense as an improvment after this.

@lwander
Copy link
Member

lwander commented Jul 21, 2017

Agreed

@lwander lwander merged commit 6c96024 into spinnaker:master Jul 21, 2017
@lwander lwander mentioned this pull request Jul 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnrengelman @lwander