Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(run): Restart daemon when PID is unknown #613

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

lwander
Copy link
Member

@lwander lwander commented Jul 19, 2017

No description provided.

@lwander lwander requested a review from jtk54 July 19, 2017 19:11
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't include my comment in the first review.

@@ -40,16 +40,27 @@ function start_daemon() {
echo ""
}

function kill_daemon() {
set +e
pkill -f '/opt/halyard/lib/halyard-web'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could || true this also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah neat

@lwander lwander force-pushed the tolerant-of-other-running-daemon branch from b65da7a to 90875ce Compare July 19, 2017 19:37
@lwander lwander merged commit f24961f into spinnaker:master Jul 19, 2017
@lwander lwander deleted the tolerant-of-other-running-daemon branch July 19, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants