Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(install): New install path #609

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

lwander
Copy link
Member

@lwander lwander commented Jul 19, 2017

The idea is:

  1. We package up the JARs & generated wrapper scripts built by gradle
  2. Users download that package as well as a script that starts the daemon when it's not running yet

Each system will need to supply a script to download java8, as well as provide a script to start the daemon when it's not running.

@lwander lwander requested a review from jtk54 July 19, 2017 13:27
@lwander lwander force-pushed the start-daemon-from-hal branch 2 times, most recently from 944d277 to 1956e39 Compare July 19, 2017 14:56
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mean for the release/halyard.tar.gz file to be in this PR? Otherwise LGTM.

echo $HAL_USER > /opt/spinnaker/config/halyard-user

cat > $halconfig_dir/uninstall.sh <<EOL
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very meta.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing that script doesn't write any scripts.

@lwander
Copy link
Member Author

lwander commented Jul 19, 2017

No, whoops - thanks.

@lwander lwander merged commit 6c0d9f0 into spinnaker:master Jul 19, 2017
@lwander lwander deleted the start-daemon-from-hal branch July 19, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants