fix(backup): Only close archive entries with data #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
force-pushed
the
only-close-archives-with-data
branch
from
d9d4380
to
5f32a20
Compare
|
Also possible: A |
lwander
force-pushed
the
only-close-archives-with-data
branch
from
5f32a20
to
d4cb341
Compare
lwander
force-pushed
the
only-close-archives-with-data
branch
from
d4cb341
to
a574d8e
Compare
danielpeach
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several users have now seen the backup controller fail to create a tar archive due to unclosed entries with fairly simply hal config directories. I haven't been able to reproduce this error, but my best guess is that archive entries created for any directory are causing grief for their local tar archiver. Reading the spec it could (?) be interpreted that only entries with data can be closed.