fix(install): Remove unneeded "start halyard" after install #604
Conversation
|
If the install fails (like we saw before) the install script should have exited already. If halyard has another bug that prevents it from starting, removing this line doesn't introduce that behavior, that would have already happened. I'll add a timeout to wait section as a friendly precaution, though. |
|
I dont see an update wiht the timeout. |
lwander
force-pushed
the
remove-unneeded-start-halyard
branch
from
13fe5b7
to
fc53248
Compare
|
Sorry got sidetracked & never pushed the timeout guard |
|
(It's here now) |
|
h/o don't merge yet |
install/InstallHalyard.sh.gen
Outdated
| WAIT_NOW=$(date +%s) | ||
| WAIT_TIME=$(( $WAIT_NOW - $WAIT_START )) | ||
|
|
||
| if [ "$WAIT_TIME" > "$HALYARD_STARTUP_TIMEOUT_SECONDS" ]; then |
There was a problem hiding this comment.
I htink this should be $WAIT_TIME -gt $HALYARD_STARTUP_TIMEOUT_SECS
There was a problem hiding this comment.
oh never mind, this is a string compare
There was a problem hiding this comment.
if you are spinning on a sleep, you can just count iterations. Approximation is good enough.
There was a problem hiding this comment.
No you're right it should be -gt
I figured counting approximations would break if someone changed the sleep time per iteration. This felt a little more consistent.
The `start halyard` command was breaking the install path after the `postInstall.sh` now correctly starts Halyard after it's installed.
lwander
force-pushed
the
remove-unneeded-start-halyard
branch
from
fc53248
to
034374d
Compare
|
All set on my end |
| WAIT_NOW=$(date +%s) | ||
| WAIT_TIME=$(( $WAIT_NOW - $WAIT_START )) | ||
|
|
||
| if [ "$WAIT_TIME" -gt "$HALYARD_STARTUP_TIMEOUT_SECONDS" ]; then |
There was a problem hiding this comment.
-gt is on numbers but you have strings here.
I think you should count iterations.
There was a problem hiding this comment.
String comparison is lexicographic, and bash variables are untyped. This does an integer comparison.
Why do you prefer counting iterations?
The
start halyardcommand was breaking the install path after thepostInstall.shnow correctly starts Halyard after it's installed.