feat(timezone): Makes timezone CLI-configurable #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duftler
reviewed
Jun 13, 2017
| DeploymentConfiguration test = deploymentConfigurations.get(i); | ||
| if (test.getName().equals(deploymentName)) { | ||
| deploymentConfigurations.set(i, deploymentConfiguration); | ||
| return; |
There was a problem hiding this comment.
Might read easier to have one block to locate the index of the matching config, and then another to set the new config. As it stands now, it looks like you are setting a new config while you are still searching through the list.
| String timezone = n.getTimezone(); | ||
|
|
||
| if (Arrays.stream(TimeZone.getAvailableIDs()).noneMatch(t -> t.equals(timezone))) { | ||
| p.addProblem(Problem.Severity.WARNING, "Timezone " + timezone + " does not match any known canonical timezone ID"); |
There was a problem hiding this comment.
Maybe provide a link to the list of canonical timezone ids?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.