Don't validate/create S3 bucket twice #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I have a similarish PR here: #536 Can you move the rest of the credential construction into the catch block and I'll close my PR? |
jervi
force-pushed
the
dont_validate_s3_bucket_twice
branch
from
55161c2
to
8bcb66a
Compare
`new S3Config().s3StorageService(s3Client, s3Properties);` calls `s3StorageService.ensureBucketExists();`, so no need to do it again. Added bonus: the catch clause actually catches exceptions.
jervi
force-pushed
the
dont_validate_s3_bucket_twice
branch
from
8bcb66a
to
cb8d4b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new S3Config().s3StorageService(s3Client, s3Properties);callss3StorageService.ensureBucketExists();, so no need to do it again.Added bonus: the catch clause actually catches exceptions.