Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deploy): Set default bake account in orca #530

Merged
merged 1 commit into from
Jun 5, 2017
Merged

fix(deploy): Set default bake account in orca #530

merged 1 commit into from
Jun 5, 2017

Conversation

lwander
Copy link
Member

@lwander lwander commented Jun 5, 2017

@lwander lwander requested a review from jtk54 June 5, 2017 21:33
jtk54
jtk54 approved these changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtk54 jtk54 merged commit d9c2c25 into spinnaker:master Jun 5, 2017
ewiseblatt
ewiseblatt reviewed Jun 5, 2017
View reviewed changes
Copy link

@ewiseblatt ewiseblatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the default, but would think you would need a way to override it (unless that's just clouddriver-local).

@lwander
Copy link
Member Author

lwander commented Jun 5, 2017

Orca & clouddriver don't otherwise share config properties, so there is no way to set a static default that depends on SPEL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewiseblatt ewiseblatt ewiseblatt left review comments

@jtk54 jtk54 jtk54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lwander @ewiseblatt @jtk54