fix(version): 'nightly' is no longer a valid alias #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewiseblatt
reviewed
May 29, 2017
| @@ -45,7 +45,7 @@ | |||
| * | |||
| * @see Halconfig#halyardVersion | |||
| */ | |||
| String version = "nightly"; | |||
| String version = "master-latest-unvalidated"; | |||
There was a problem hiding this comment.
why is this "master"?
doesnt "master" refer to the branch?
There was a problem hiding this comment.
Yup - it's effectively what "nightly" was before we stopped using that alias.
There was a problem hiding this comment.
I mean, how do you know you are in master? This shouldnt be a static string. In fact none of the tag should be. The naming policy should be defined externally.
There was a problem hiding this comment.
This is a default/placeholder before we get have a proper "latest" alias that points to the latest validated Spinnaker. I know that for the next week before we release, this alias is just a QOL improvement that effectively points at what "nightly" pointed at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.