-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Configure metric stores via CLI #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing comments.
|
||
new OperationHandler<MetricStores>() | ||
.setOperation(Daemon.getMetricStores(currentDeployment, !noValidate)) | ||
.setFailureMesssage("Failed to metric stores.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/to metric/to configure metric
|
||
new OperationHandler<Void>() | ||
.setOperation(Daemon.setMetricStores(currentDeployment, !noValidate, metricStores)) | ||
.setFailureMesssage("Failed to edit metric stores.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're calling .setFailureMessage()
twice here.
} | ||
|
||
new OperationHandler<Void>() | ||
.setOperation(Daemon.setMetricStores(currentDeployment, !noValidate, metricStores)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order in which these methods are chained changed from the last class to this one.
PTAL