Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider/kubernetes): v1 - pass account service account to kubecfg parser #1066

Merged
1 commit merged into from Oct 15, 2018
Merged

fix(provider/kubernetes): v1 - pass account service account to kubecfg parser #1066

1 commit merged into from Oct 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2018

Making a PR for discussion on Monday.

Issue here: spinnaker/spinnaker#3435 (comment)

This user of the spinnaker helm chart is attempting to deploy a v1 account but seeing an error because the kubecfg is null. It looks like the kubecfg parser can deal with this by using the provided service account instead but needs to be instructed to do so.

I'm having some trouble compiling this to test against. Getting the following gradle error:

 (master) λ ./gradlew clean
Inferred project: halyard, version: 0.37.0-SNAPSHOT

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/sbws/dev/spinnaker/halyard/build.gradle' line: 36

* What went wrong:
A problem occurred evaluating root project 'halyard'.
> Failed to apply plugin [class 'com.netflix.spinnaker.gradle.project.SpinnakerProjectConventionsPlugin']
   > index is out of range 0..-1 (index = 0)

@ghost ghost requested a review from lwander October 12, 2018 21:03
@lwander
Copy link
Member

lwander commented Oct 15, 2018

Nice, thanks!

@ghost ghost merged commit 7e64227 into spinnaker:master Oct 15, 2018
@ghost ghost deleted the k8s-v1-pass-service-account-to-kubecfg-parser branch October 15, 2018 14:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants