fix(web): restore check for regenerateCronTriggerIds in PipelineController.save #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of making Maps and casting
…oller.save https://github.com/spinnaker/front50/pull/1035/files#diff-9b514be177faf5444c86a88ab6bb9e6a0add032bfa67862bc8e33b17c4bb9cc9L159 removed it, but orca's SavePipelineTask still sets it.
The comment in https://github.com/spinnaker/front50/pull/987/files#r515405296 is no longer true after spinnaker#1035. Pipeline.getTriggers no longer makes a copy, so there's no need to get/modify/set.
dbyron-sf
commented
Apr 4, 2024
| // ensure that cron triggers are assigned a unique identifier for new pipelines | ||
| List<Trigger> triggers = pipeline.getTriggers(); | ||
| triggers.stream() | ||
| pipeline.getTriggers().stream() |
There was a problem hiding this comment.
https://github.com/spinnaker/front50/pull/987/files#r515405296 is no longer valid after https://github.com/spinnaker/front50/pull/1035/files#diff-0b2bc300fd3965c64ba4184955384aa8609cace04e1c015b31ef4a83552e53d1R36. There's no need to get/modify/set anymore.
jasonmcintosh
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/spinnaker/front50/pull/1035/files#diff-9b514be177faf5444c86a88ab6bb9e6a0add032bfa67862bc8e33b17c4bb9cc9L159 removed it, but orca's SavePipelineTask still sets it.
with some little refactors along the way.