-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deploy/ecs): add ecs support #5190
Conversation
@@ -110,6 +110,7 @@ window.spinnakerSettings = { | |||
}, | |||
useAmiBlockDeviceMappings: false, | |||
}, | |||
ecs: ecs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the ecs
variable defined? This appears to be a lint error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melbit-michaelw other providers define defaults. You probably want to do something like this:
defaults: {
account: 'test',
region: 'us-east-1',
iamRole: 'BaseIAMRole',
},```
I am not sure where these defaults are used though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbwsg , @BrunoCarrier Added the var definition for ecs, and changed the commit message to be fix based rather than feature.
bce974b
to
29b54b6
Compare
Sorry. That last commit dragged in more than I intended. I’ll fix it when I get to work in the morning and tag you to let you know. |
ok great ping me when it's readdy and i'll cherry-pick it into the 1.7 release branch. |
02d4735
to
83aded8
Compare
83aded8
to
3a31ae1
Compare
It appears the git hooks were reformatting the code.. I've re-committed without enabling them, and now it looks as I expected. I'm not sure why they were a problem.. @sbwsg Ready for your review. |
lgtm |
Adding ECS functionality into Deck. There will also be a halyard Pull request associated with this work.