feat(deploy/ecs): add ecs support #5190
Conversation
| @@ -110,6 +110,7 @@ window.spinnakerSettings = { | |||
| }, | |||
| useAmiBlockDeviceMappings: false, | |||
| }, | |||
| ecs: ecs, | |||
There was a problem hiding this comment.
Where is the ecs variable defined? This appears to be a lint error.
There was a problem hiding this comment.
@melbit-michaelw other providers define defaults. You probably want to do something like this:
defaults: {
account: 'test',
region: 'us-east-1',
iamRole: 'BaseIAMRole',
},```
I am not sure where these defaults are used though
There was a problem hiding this comment.
@sbwsg , @BrunoCarrier Added the var definition for ecs, and changed the commit message to be fix based rather than feature.
melbit-michaelw
force-pushed
the
ecs-support
branch
2 times, most recently
from
bce974b
to
29b54b6
Compare
|
Sorry. That last commit dragged in more than I intended. I’ll fix it when I get to work in the morning and tag you to let you know. |
|
ok great ping me when it's readdy and i'll cherry-pick it into the 1.7 release branch. |
melbit-michaelw
force-pushed
the
ecs-support
branch
from
02d4735
to
83aded8
Compare
melbit-michaelw
force-pushed
the
ecs-support
branch
from
83aded8
to
3a31ae1
Compare
|
It appears the git hooks were reformatting the code.. I've re-committed without enabling them, and now it looks as I expected. I'm not sure why they were a problem.. @sbwsg Ready for your review. |
ghost
merged commit
|
lgtm |
ghost
mentioned this pull request
Adding ECS functionality into Deck. There will also be a halyard Pull request associated with this work.