This repository was archived by the owner on Dec 20, 2025. It is now read-only.
feat(aws): CleanupAlarmsAgent with an optional user-defined name pattern#6317
Merged
mergify[bot] merged 1 commit intospinnaker:masterfrom Dec 13, 2024
Merged
Conversation
christosarvanitis
requested review from
ajordens and
jeyrschabu
as code owners
jasonmcintosh
approved these changes
Dec 13, 2024
Member
jasonmcintosh
left a comment
jasonmcintosh
left a comment
There was a problem hiding this comment.
nit: Should be a feature. yes it's config flagged
christosarvanitis
force-pushed
the
AWSAlarmsCleanupAgent
branch
from
1dc05f1 to
3458f92
Compare
christosarvanitis
changed the title
jasonmcintosh
approved these changes
Dec 13, 2024
Member
|
@Mergifyio backport release-1.35.x release-1.36.x release-1.34.x |
Contributor
✅ Backports have been createdDetails
|
This was referenced Dec 13, 2024
Merged
Merged
christosarvanitis
added a commit
to armory-io/clouddriver
that referenced
this pull request
Dec 13, 2024
christosarvanitis
added a commit
to armory-io/clouddriver
that referenced
this pull request
Jan 29, 2025
christosarvanitis
added a commit
to armory-io/clouddriver
that referenced
this pull request
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users might defined a custom name for the scaling policies and alarms names that dont match the strict namePattern of the AlarmsCleanUp agent.
Especially for custom alarms when a scaling policy is deleted the alarms are not cascade deleted leading to stale cache in the cats_v1_alarms table.
This PR allows the user to define their own AlarmsNamePattern for the AlarmsCleanupAgent