Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor oracle bmcs #2702

Merged
merged 4 commits into from
Jun 13, 2018
Merged

Conversation

guoyongzhang
Copy link
Contributor

The name oraclebmcs is no longer used in Oracle product offering. To avoid confusion, spinnaker provider "oracebmcs" is replaced with the name "oracle".
halyard has made this refactoring in spinnaker/halyard#959.

@robzienert
Copy link
Member

@guoyongzhang Is this just renaming things, are there any backwards-incompatible changes that will require users to change pipeline configurations, etc?

Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick scan this will:

  1. Change required configuration,
  2. Force users to flush redis caches,
  3. Require pipeline stages to change their configured "cloudProvider" field.

@robzienert
Copy link
Member

@guoyongzhang How critical is this PR being merged quickly? For example, is there in-flight work that will soon be PR'ed that depends on this refactor?

@markxnelson
Copy link

We do have work planned that will depend on this, but it is not imminent. We are going to try to determine if anyone actually ever used this, we suspect not, because it is incomplete as-is, and we are working on finishing it. For example it does not have server groups and it does not have any support for building images yet. We certainly do not want to cause any user impact, and we are happy to work with you to minimize the impact, or align it with a release or whatever makes sense. Can you confirm if this change as-is would require all users to do those things, or just people who actually used this provider?

@lwander
Copy link
Member

lwander commented Jun 12, 2018 via email

@markxnelson
Copy link

As per out of band email discussion with @aglover @gilbode and @owainlewis I believe we are in agreement to merge this

@robzienert
Copy link
Member

Cool dudes. Thanks for the patience.

@robzienert robzienert merged commit 28f0167 into spinnaker:master Jun 13, 2018
@guoyongzhang guoyongzhang deleted the refactor-oracle-bmcs branch June 14, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants