-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor oracle bmcs #2702
Refactor oracle bmcs #2702
Conversation
@guoyongzhang Is this just renaming things, are there any backwards-incompatible changes that will require users to change pipeline configurations, etc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick scan this will:
- Change required configuration,
- Force users to flush redis caches,
- Require pipeline stages to change their configured "cloudProvider" field.
@guoyongzhang How critical is this PR being merged quickly? For example, is there in-flight work that will soon be PR'ed that depends on this refactor? |
We do have work planned that will depend on this, but it is not imminent. We are going to try to determine if anyone actually ever used this, we suspect not, because it is incomplete as-is, and we are working on finishing it. For example it does not have server groups and it does not have any support for building images yet. We certainly do not want to cause any user impact, and we are happy to work with you to minimize the impact, or align it with a release or whatever makes sense. Can you confirm if this change as-is would require all users to do those things, or just people who actually used this provider? |
These changes (as far as I can tell) only impact users of this provider.
…On Tue, Jun 12, 2018 at 10:59 AM Mark Nelson ***@***.***> wrote:
We do have work planned that will depend on this, but it is not imminent.
We are going to try to determine if anyone actually ever used this, we
suspect not, because it is incomplete as-is, and we are working on
finishing it. For example it does not have server groups and it does not
have any support for building images yet. We certainly do not want to cause
any user impact, and we are happy to work with you to minimize the impact,
or align it with a release or whatever makes sense. Can you confirm if this
change as-is would require *all* users to do those things, or just people
who actually used this provider?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2702 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEpivYy6TU81maBjeWGcKVN0LD5TLFk2ks5t79dDgaJpZM4Ui9Br>
.
|
As per out of band email discussion with @aglover @gilbode and @owainlewis I believe we are in agreement to merge this |
Cool dudes. Thanks for the patience. |
The name oraclebmcs is no longer used in Oracle product offering. To avoid confusion, spinnaker provider "oracebmcs" is replaced with the name "oracle".
halyard has made this refactoring in spinnaker/halyard#959.