Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(redis): JedisPool metrics (numActive, numIdle, numWaiters) #2681

Merged
merged 1 commit into from
Jun 1, 2018
Merged

chore(redis): JedisPool metrics (numActive, numIdle, numWaiters) #2681

merged 1 commit into from
Jun 1, 2018

Conversation

ajordens
Copy link
Contributor

@ajordens ajordens commented Jun 1, 2018

Also updated the ClusteredAgentScheduler to compare getAgentType()
rather than agent.class.simpleName when determining whether the
agent should be scheduled.

@ajordens
chore(redis): JedisPool metrics (numActive, numIdle, numWaiters)
403d8c9 
Also updated the `ClusteredAgentScheduler` to compare `getAgentType()`
rather than `agent.class.simpleName` when determining whether the
agent should be scheduled.
jrsquared
jrsquared approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@jrsquared jrsquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@ajordens ajordens merged commit 81b1098 into spinnaker:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrsquared jrsquared jrsquared approved these changes

@emjburns emjburns Awaiting requested review from emjburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajordens @jrsquared