fix(logs): add more caching info #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajordens
reviewed
Jun 1, 2018
| @@ -102,7 +104,7 @@ public ClusteredAgentScheduler(RedisClientDelegate redisClientDelegate, | |||
| Set<String> skip = new HashSet<>(activeAgents.keySet()); | |||
| Integer availableAgents = maxConcurrentAgents - skip.size(); | |||
| if (availableAgents <= 0) { | |||
| logger.debug("Not acquiring more locks (activeAgents: " + skip.size() + " >= maxConcurrentAgents " + maxConcurrentAgents + ")"); | |||
| logger.debug("Not acquiring more locks (activeAgents: " + skip.size() + " >= " + maxConcurrentAgents + "). Running agents: " + skip.stream().sorted().collect(Collectors.joining(","))); | |||
There was a problem hiding this comment.
lets get this merged and pushed ...
as an aside, try and avoid lines < 120 characters ...
logger.debug(
"Not acquiring more locks (activeAgents: {}, runningAgents: {})",
skip.size(),
skip.stream().sorted().collect(Collectors.joining(","))
)
^^ makes it easy to do for logs
There was a problem hiding this comment.
Sounds good to all. Will make those changes!
lwander
pushed a commit
to lwander/clouddriver
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more logs to help track down some clouddriver shenanigans.