perf(cats): Deserialize relationships into Set vs List
#2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajordens
commented
May 29, 2018
| @@ -202,7 +202,7 @@ private boolean validType(String type) { | |||
| if (relationship == null) { | |||
| return new HashSet<>(); | |||
| } | |||
| return relationship; | |||
| return relationship instanceof Set ? (Set<String>) relationship : new HashSet<>(relationship); | |||
There was a problem hiding this comment.
this is probably not necessary as the deserialization is now to a Set but figured it was worth being explicit.
We have many implementations of CacheData and I did not immediately want to go down the path of changing constructors to move away from Collection<String> for relationships.
Reasonable?
ajordens
added a commit
to ajordens/clouddriver
that referenced
this pull request
May 30, 2018
Similar to spinnaker#2666 but this time behind a `caching.redis.treatRelationshipsAsSet` flag.
ajordens
added a commit
to ajordens/clouddriver
that referenced
this pull request
May 30, 2018
Similar to spinnaker#2666 but this time behind a `caching.redis.treatRelationshipsAsSet` flag.
ajordens
added a commit
that referenced
this pull request
May 30, 2018
Similar to #2666 but this time behind a `caching.redis.treatRelationshipsAsSet` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.