Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider/kubernetes): fix looking up non-namespaced manis #2634

Merged
merged 1 commit into from
May 17, 2018
Merged

fix(provider/kubernetes): fix looking up non-namespaced manis #2634

merged 1 commit into from
May 17, 2018

Conversation

lwander
Copy link
Member

@lwander lwander commented May 17, 2018

@lwander lwander requested a review from jtk54 May 17, 2018 17:19
jtk54
jtk54 approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lwander lwander merged commit 7570e8c into spinnaker:master May 17, 2018
lwander added a commit to lwander/clouddriver that referenced this pull request May 17, 2018
@lwander
fix(provider/kubernetes): support looking up non-namespaced manis (sp…
54e574d 
…innaker#2634)
lwander added a commit that referenced this pull request May 17, 2018
@lwander
fix(provider/kubernetes): support looking up non-namespaced manis (#2634
ddc5738 
) (#2635)
@lwander lwander deleted the empty-manifest-char branch May 17, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtk54 jtk54 jtk54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes V2 Fail For Global Resources (ClusterRole, ClusterRoleBinding)
2 participants
@lwander @jtk54