feat: allow component selector during spin up#903
Closed
rawkode wants to merge 5 commits intospinframework:mainfrom
rawkode:feat/allow-component-selection-for-up
Closed
feat: allow component selector during spin up#903rawkode wants to merge 5 commits intospinframework:mainfrom rawkode:feat/allow-component-selection-for-up
rawkode wants to merge 5 commits intospinframework:mainfrom
rawkode:feat/allow-component-selection-for-up
Conversation
itowlson
requested changes
Nov 22, 2022
I find myself often wanting to iterate on a single component within my Spin application, instead of building them all; this can take considerable time as my applicationg grows. This selector allows a single, or multiple, uses of --component/-c to limit the components specified by the user. Signed-off-by: David Flanagan <david@rawkode.dev>
Signed-off-by: David Flanagan <david@rawkode.dev>
Signed-off-by: David Flanagan <david@rawkode.dev>
Signed-off-by: David Flanagan <david@rawkode.dev>
itowlson
requested changes
Dec 18, 2022
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Looks good - thanks in particular for improving the error messages. Just one change to prevent surprises (in a little-used path, but still) and then we are good to go!
Signed-off-by: David Flanagan <david@rawkode.dev>
itowlson
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find myself often wanting to iterate on a single component within my Spin application, instead of building them all; this can take considerable time as my applicationg grows.
This selector allows a single, or multiple, uses of --component/-c to limit the components specified by the user.