Allow configurable max buffer size for HTTP connections #3349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Hardock <[email protected]>
fibonacci1729
force-pushed
the
max-buf-size
branch
from
753e125 to
148e202
Compare
itowlson
approved these changes
Nov 5, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
One day (O HAPPY DAY) we should come up with some principles about when to use trigger args vs trigger config vs runtime config vs pure environment variables.
Today, however, need not be that day.
(This thought is prompted by the assumption that the user in the linked issue is going to want their application to always run with this buffer size. But it seems a bit low level for a trigger config setting, so 🤷.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
SPIN_HTTP1_MAX_BUF_SIZEto allow configuring the underlying maximum read buffer size for HTTP1 connections.