Adds allow_unset field for variables #3273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
lann
requested changes
Sep 16, 2025
There was a problem hiding this comment.
We don't have a way to represent "default unset" in spin:variables/get. I think currently it would just return error.undefined which can't be distinguished from mistyping the name.
As-is I think this change isn't worth it when the alternative of default = "" will probably handle the vast majority of cases where this would be useful. If we really want to do this I think spin:variables should be revised to explicitly represent this case through e.g. a new error variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve #3053
Offers an option for variables unset