node-installer: fixes for containerd 2#301
Merged
kate-goldenring merged 3 commits intospinframework:mainfrom Mar 28, 2025
Merged
node-installer: fixes for containerd 2#301kate-goldenring merged 3 commits intospinframework:mainfrom
kate-goldenring merged 3 commits intospinframework:mainfrom
Conversation
shirok1
requested review from
Mossaka,
devigned,
jsturtevant,
kate-goldenring and
radu-matei
as code owners
Contributor
Author
This comment was marked as resolved.
This comment was marked as resolved.
shirok1
force-pushed
the
fix-node-installer-containerd-2
branch
from
639588e to
0d7dd1d
Compare
Mossaka
approved these changes
Mar 27, 2025
Member
Mossaka
left a comment
Mossaka
left a comment
There was a problem hiding this comment.
LGTM! @kate-goldenring can you PTAL?
Member
|
Need a rebase |
kate-goldenring
approved these changes
Mar 27, 2025
Collaborator
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
LGTM thank you!
shirok1
force-pushed
the
fix-node-installer-containerd-2
branch
2 times, most recently
from
08b1b91 to
8a5219d
Compare
Signed-off-by: Shiroki Satsuki <me@shirok1.dev> # Conflicts: # node-installer/script/installer.sh
Signed-off-by: Shiroki Satsuki <me@shirok1.dev>
node-installer: fix symbolic link to path containing $NODE_ROOT node-installer: clearify containerd bug Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com> Signed-off-by: Shiroki Satsuki <me@shirok1.dev>
shirok1
force-pushed
the
fix-node-installer-containerd-2
branch
from
8a5219d to
e513c36
Compare
shirok1
commented
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #231 (comment)