cleanup: use component filtering utils from Spin crates#213
Merged
kate-goldenring merged 2 commits intospinframework:mainfrom Jan 17, 2025
Merged
cleanup: use component filtering utils from Spin crates#213kate-goldenring merged 2 commits intospinframework:mainfrom
kate-goldenring merged 2 commits intospinframework:mainfrom
Conversation
kate-goldenring
force-pushed
the
remove-retain-module
branch
from
01f92d2 to
9aca3b5
Compare
kate-goldenring
requested review from
devigned,
jsturtevant and
radu-matei
as code owners
Member
|
LGTM, can you please update the changelog to include this change? |
Mossaka
reviewed
Jan 16, 2025
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
remove-retain-module
branch
from
9aca3b5 to
6a876be
Compare
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In spinframework/spin#2892, we moved component filtering helpers to the
spin-appandspin-factor-outbound-networkingcrates, so runtimes can remove duplicated code. This utilizes those crates, allowing us to remove much of the duplicated code that was added in #197DRAFT TILL: We will need to bump the triggers' spin crate (locked and app) versions in order to then bump this. We could put this on hold until we bump Spin crates for other reasons -- maybe 3.0