Conversation
Mossaka
requested review from
devigned,
jsturtevant,
kate-goldenring and
radu-matei
as code owners
Mossaka
commented
Sep 10, 2024
Mossaka
force-pushed
the
refactoring
branch
from
71255a7 to
7e35184
Compare
kate-goldenring
approved these changes
Sep 10, 2024
Collaborator
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this reorganization
Mossaka
force-pushed
the
refactoring
branch
from
7e35184 to
5d8c10f
Compare
Member
Author
|
Containerd logs for the failured spin wasm workloads: |
Mossaka
force-pushed
the
refactoring
branch
from
5d8c10f to
df5cd15
Compare
Collaborator
|
@Mossaka I wonder if tests that used to run sequentially are now running in parallel or if this is a race case. In the integration tests, maybe we should randomize the host port for port forwarding rather than keeping it always at 8082 |
Member
Author
That might be a good idea in general, but it won't help in this case, cuz I can reproduce it in my local running |
4 tasks
this commit organized code to different modules: - constants: to handling constants across entire crate - engine: the execution engine - source: manages application sources - stdio_hook: a trigger hook for stdio - trigger: manages spin triggers - utils: utility functions it also removes ResolvedAppSource as it's not needed Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
…d of Vec Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Mossaka
force-pushed
the
refactoring
branch
from
7086cb3 to
79d54ba
Compare
Member
Author
|
is fixed by 79d54ba |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit organized code to different modules:
it also removes ResolvedAppSource as it's not needed