Skip to content

Replace dtolnay/rust-toolchain action with rustup show#598

Merged
indirect merged 2 commits intospinel-coop:mainfrom
shaanmajid:ci/rustup-show
Mar 10, 2026
Merged

Replace dtolnay/rust-toolchain action with rustup show#598
indirect merged 2 commits intospinel-coop:mainfrom
shaanmajid:ci/rustup-show

Conversation

@shaanmajid
Copy link
Copy Markdown
Contributor

@shaanmajid shaanmajid commented Mar 10, 2026

Replaces dtolnay/rust-toolchain@stable with rustup show, which installs the toolchain from rust-toolchain.toml directly. Follows up on #593 (comment).

  • Eliminates the dtolnay/rust-toolchain third-party dependency
  • Currently, the action installs latest stable (1.94.0), but cargo ignores it in favor of
    the 1.93.1 pinned in rust-toolchain.toml
  • Adds CARGO_INCREMENTAL: 0 to disable incremental compilation in CI, where builds always
    start clean and the cached artifacts are never reused.
  • Adds a CARGO_HOME fallback in the windows-11-arm nextest workaround

The last two compensate for side-effects of the removed action: dtolnay/rust-toolchain exported both CARGO_INCREMENTAL=0 and CARGO_HOME into GITHUB_ENV as part of its setup. CARGO_INCREMENTAL affects all runners; CARGO_HOME only affected windows-11-arm, where the runner image doesn't set it by default.

@shaanmajid shaanmajid changed the title ci: replace dtolnay/rust-toolchain with rustup show Replace dtolnay/rust-toolchain action with rustup show Mar 10, 2026
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@indirect indirect added this pull request to the merge queue Mar 10, 2026
Merged via the queue into spinel-coop:main with commit ec0c31f Mar 10, 2026
27 checks passed
@shaanmajid shaanmajid deleted the ci/rustup-show branch March 10, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants