Skip to content

Add zizmor for GitHub Actions security scanning#578

Merged
indirect merged 2 commits intospinel-coop:mainfrom
shaanmajid:ci/add-zizmor
Mar 8, 2026
Merged

Add zizmor for GitHub Actions security scanning#578
indirect merged 2 commits intospinel-coop:mainfrom
shaanmajid:ci/add-zizmor

Conversation

@shaanmajid
Copy link
Copy Markdown
Contributor

Summary

  • Add a dedicated zizmor workflow, a static analysis tool for finding security issues in GitHub Actions workflows
  • Fix the easy stuff: narrowed read-all permissions to contents: read, added persist-credentials: false to all checkouts
  • Exempted release.yml findings since it's autogenerated by cargo-dist
  • SHA pinning (unpinned-uses) is disabled for now, see comment below

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@shaanmajid
Copy link
Copy Markdown
Contributor Author

SHA pinning is the main remaining finding. This is what would've prevented the tj-actions/changed-files supply chain attack (CVE-2025-30066), where an attacker moved version tags to point at a malicious commit, leaking CI secrets from thousands of repos. Repos that had pinned to a commit SHA were unaffected.

Dependabot already handles bumping both the SHA and the version comment together, so maintenance shouldn't be a problem. Just wanted ot hold off since it'll touch every action reference across all the workflows, so the diff will be big but entirely mechanical. Happy to do it in a follow-up if there's support.

Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with pinning actions later, too, but let's see what others think!

@indirect
Copy link
Copy Markdown
Member

indirect commented Mar 8, 2026

Sounds good to me.

@indirect indirect added this pull request to the merge queue Mar 8, 2026
Merged via the queue into spinel-coop:main with commit 82ee6a2 Mar 8, 2026
27 checks passed
@shaanmajid shaanmajid deleted the ci/add-zizmor branch March 8, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants