Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not update json sidecar if the label file was not modified #19

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Do not update json sidecar if the label file was not modified #19

merged 1 commit into from
Mar 2, 2023

Conversation

valosekj
Copy link
Member

@valosekj valosekj commented Feb 28, 2023 •
edited
Loading

The manual_correction.py script now checks if the label file was modified or not. If the label file was not modified, the json sidecar is not updated.

Fixes: #7

@valosekj valosekj mentioned this pull request Feb 28, 2023
Merged
5 tasks
sandrinebedard
sandrinebedard approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@sandrinebedard sandrinebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out and it works well! Thank you @valosekj !

@valosekj
Copy link
Member Author

valosekj commented Mar 2, 2023

Thanks @sandrinebedard! Merging.

@valosekj valosekj merged commit 1fbdf3d into main Mar 2, 2023
@valosekj valosekj deleted the jv/7-do_not_update_json_file branch March 2, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrinebedard sandrinebedard sandrinebedard approved these changes

@naga-karthik naga-karthik Awaiting requested review from naga-karthik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON files updated despite no manual correction
2 participants
@valosekj @sandrinebedard