Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POST ClusterFederatedTrustDomain API #549

Merged
merged 23 commits into from
Jan 21, 2025
Merged

Conversation

maia-iyer
Copy link
Collaborator

@maia-iyer maia-iyer commented Oct 30, 2024

Partially addresses #543 by implementing the POST API.

Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer maia-iyer marked this pull request as ready for review November 18, 2024 14:12
@maia-iyer maia-iyer self-assigned this Nov 18, 2024
@maia-iyer maia-iyer changed the title Post federation crd Add POST ClusterFederatedTrustDomain API Nov 18, 2024
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer maia-iyer added the backend Tornjak API (Backend) label Nov 21, 2024
@maia-iyer maia-iyer added go Pull requests that update Go code Ready For Review labels Nov 21, 2024
@maia-iyer maia-iyer added this to the 2.0.0 milestone Jan 14, 2025
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except one nit which is not urgent.

pkg/agent/spirecrd/helpers.go Show resolved Hide resolved
@maia-iyer maia-iyer merged commit 34cf316 into main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) go Pull requests that update Go code Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants