Update to Go 1.24.0

[rturner3]

• Update RSA keys used in tests to have >= 1024 bits. rsa.GenerateKey() in Go 1.24 now throws errors when a key size < 1024 bits is used: https://pkg.go.dev/crypto/rsa#hdr-Minimum_key_size
• Update internal fork of golang.org/x/crypto/acme/autocert/internal/acmetest to the version from v0.33.0. There are changes to this file that are required for Go 1.24 compatibility, see CL for reference. Existing changes to the fork of this file were preserved.
  • One additional forked change was required to disable a newly added behavior upstream that causes any tests that encounter HTTP errors in the CA to fail. This was required to preserve our existing unit test TestACMEAuth/new-account-tos-not-accepted from pkg/server/endpoints/bundle/server_test.go that verifies some of the forked behavior around ACME CA Terms of Service being accepted. This deviation was annotated with a comment in the forked pkg/server/endpoints/bundle/internal/acmetest/ca.go file.
• Rework the TestACMEAuth subtests in pkg/server/endpoints/bundle/server_test.go to accommodate newer behavior of the forked acmetest CA from golang.org/x/crypto. acmetest.CAServer now has a Start() method that must be called to generate the root CA certificate and URL for the fake server. This method also registers a closer method as a test cleanup method. This resulted in a few changes to the tests:
  • Every subtest now needs its own acmetest.CAServer since they are not reusable across tests due to the closer method being registered as a test cleanup method
  • The cached subtest needed to be merged with the initial subtest because it depended on acmetest.CAServer state that can no longer be shared across subtests
• Suppress new staticcheck linter warnings related to importing deprecated OPA v0 packages

[sorindumitru]

Looks like there some extra changes in the diff from merges, would you mind rebasing again to clean things up a bit?

[rturner3]

Looks like there some extra changes in the diff from merges, would you mind rebasing again to clean things up a bit?

Hmm, one of the merges must have gotten messed up. I just rebased on main, I think it's in a better state now.